lkml.org 
[lkml]   [2023]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] wifi: rtl8xxxu: fix LED control code of RTL8192FU
Date
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
>
> Can you explain in the commit message why you changed the
> LED_ON and LED_OFF branches? It's not obvious to me and they
> don't have anything to do with the hardware-controlled blinking.
>

Hi,

Sorry that I didn't explain this clearly.
After some researches these days, I came to some conclusions:

1. The LED of MERCURY MW310UH and COMFAST CF-826F seems to be controlled by
REG_LEDCFG1, and currently rtl8xxxu controls the LED through writing
some suitable values to this register, so MW310UH and CF-826F work fine
with rtl8xxxu.

2. The LED of ASUS USB-N13 C1 seems to be controlled by another register
"REG_LEDCFG0" for unknown reason, so when I write 1 or 2 to
/sys/class/leds/rtl8xxxu-usbX-Y/brightness, the LED doesn't turn on
or blink because the register "REG_LEDCFG0" is not filled with a suitable
value, This is why I changed the LED_ON and LED_OFF branches.

I will modify the commit message in the next version of patch, thanks.

\
 
 \ /
  Last update: 2023-09-11 22:50    [W:0.066 / U:1.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site