Messages in this thread Patch in this message | | | From | Cong Liu <> | Subject | [PATCH] fix build error in function vfio_combine_iova_ranges | Date | Tue, 12 Sep 2023 09:07:36 +0800 |
| |
when compiling with smatch check, the following errors were encountered:
drivers/vfio/vfio_main.c:957 vfio_combine_iova_ranges() error: uninitialized symbol 'last'. drivers/vfio/vfio_main.c:978 vfio_combine_iova_ranges() error: potentially dereferencing uninitialized 'comb_end'. drivers/vfio/vfio_main.c:978 vfio_combine_iova_ranges() error: potentially dereferencing uninitialized 'comb_start'.
this patch fix these error.
Signed-off-by: Cong Liu <liucong2@kylinos.cn> --- drivers/vfio/vfio_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c index 40732e8ed4c6..68a0a5081161 100644 --- a/drivers/vfio/vfio_main.c +++ b/drivers/vfio/vfio_main.c @@ -938,12 +938,13 @@ static int vfio_ioctl_device_feature_migration(struct vfio_device *device, void vfio_combine_iova_ranges(struct rb_root_cached *root, u32 cur_nodes, u32 req_nodes) { - struct interval_tree_node *prev, *curr, *comb_start, *comb_end; + struct interval_tree_node *prev, *curr; + struct interval_tree_node *comb_start = NULL, *comb_end = NULL; unsigned long min_gap, curr_gap; /* Special shortcut when a single range is required */ if (req_nodes == 1) { - unsigned long last; + unsigned long last = 0; comb_start = interval_tree_iter_first(root, 0, ULONG_MAX); curr = comb_start; -- 2.34.1 I'm very sorry, I compiled the code on another machine and then copied the wrong patch.
| |