| Date | Mon, 11 Sep 2023 15:30:11 +0800 | Subject | Re: [PATCH v20 28/30] LoongArch: KVM: Enable kvm config and add the makefile | From | WANG Xuerui <> |
| |
On 8/31/23 16:30, Tianrui Zhao wrote: > [snip] > + > +config AS_HAS_LVZ_EXTENSION > + def_bool $(as-instr,hvcl 0)
Upon closer look it looks like this piece could use some improvement as well: while presence of "hvcl" indeed always implies full support for LVZ instructions, "hvcl" however isn't used anywhere in the series, so it's not trivially making sense. It may be better to test for an instruction actually going to be used like "gcsrrd". What do you think?
-- WANG "xen0n" Xuerui
Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/
|