Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Mon, 11 Sep 2023 14:56:23 +0200 | Subject | Re: [PATCH v5] gpio: sim: don't fiddle with GPIOLIB private members |
| |
On Mon, Sep 11, 2023 at 2:54 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Mon, Sep 11, 2023 at 01:07:40PM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > We access internals of struct gpio_device and struct gpio_desc because > > it's easier but it can actually be avoided and we're working towards a > > better encapsulation of GPIO data structures across the kernel so let's > > start at home. > > > > Instead of checking gpio_desc flags, let's just track the requests of > > GPIOs in the driver. We also already store the information about > > direction of simulated lines. > > > > For kobjects needed by sysfs callbacks: we can iterate over the children > > devices of the top-level platform device and compare their fwnodes > > against the one passed to the init function from probe. > > > > While at it: fix one line break and remove the untrue part about > > configfs callbacks using dev_get_drvdata() from a comment. > > (Just wondering if you used --patience) >
I may have forgotten this one time. I need to add an alias.
Bart
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > -- > With Best Regards, > Andy Shevchenko > >
| |