lkml.org 
[lkml]   [2023]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ntb_perf: Fix printk format
On Sun, Sep 10, 2023 at 12:34:34AM -0700, Max Hawking wrote:
> The correct printk format is %pa or %pap, but not %pa[p].
>
> Fixes: 99a06056124d ("NTB: ntb_perf: Fix address err in perf_copy_chunk")
> Signed-off-by: Max Hawking <maxahawking@sonnenkinder.org>
> ---
> drivers/ntb/test/ntb_perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
> index 553f1f46bc66..72bc1d017a46 100644
> --- a/drivers/ntb/test/ntb_perf.c
> +++ b/drivers/ntb/test/ntb_perf.c
> @@ -1227,7 +1227,7 @@ static ssize_t perf_dbgfs_read_info(struct file
> *filep, char __user *ubuf,
> "\tOut buffer addr 0x%pK\n", peer->outbuf);
>
> pos += scnprintf(buf + pos, buf_size - pos,
> - "\tOut buff phys addr %pa[p]\n", &peer->out_phys_addr);
> + "\tOut buff phys addr %pap\n", &peer->out_phys_addr);
>
> pos += scnprintf(buf + pos, buf_size - pos,
> "\tOut buffer size %pa\n", &peer->outbuf_size);
> --
> 2.41.0

For some reason this patch isn't applying cleanly for me, I'm seeing
the following issue:
$ b4 am -o - f2fb85b9-278d-9e12-b61c-d951c71bf2f6@gmx.net | patch -p1

...

patching file drivers/ntb/test/ntb_perf.c
patch: **** malformed patch at line 23: *filep, char __user *ubuf,

Please rebase and resend.

Thanks,
Jon

\
 
 \ /
  Last update: 2023-09-10 17:05    [W:0.047 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site