Messages in this thread | | | From | Biju Das <> | Subject | RE: [PATCH 1/2] power: supply: bq24257_charger: Make chip type and name in sync | Date | Sun, 10 Sep 2023 07:10:06 +0000 |
| |
Hi Andy Shevchenko,
> Subject: Re: [PATCH 1/2] power: supply: bq24257_charger: Make chip type and > name in sync > > On Sat, Sep 02, 2023 at 08:33:30PM +0100, Biju Das wrote: > > Add struct bq2425x_chip_info to make enum bq2425x_chip and it's name > > in sync and replace chip->info in struct bq24257_device and add struct > > bq2425x_chip_info as match data for OF/ACPI/ID tables. > > > > Simpilfy probe() by replacing acpi_match_device() and id lookup for > > retrieving match data by using i2c_get_match_data(). > > > > Drop bq2425x_chip_name as there is no user and also drop the comment > > related to syncing chip and name as it is taken care by struct > > bq2425x_chip_info. > > ... > > > - if (ACPI_HANDLE(dev)) { > > - acpi_id = acpi_match_device(dev->driver->acpi_match_table, > > - &client->dev); > > - if (!acpi_id) { > > - dev_err(dev, "Failed to match ACPI device\n"); > > - return -ENODEV; > > - } > > - bq->chip = (enum bq2425x_chip)acpi_id->driver_data; > > - } else { > > - bq->chip = (enum bq2425x_chip)id->driver_data; > > - } > > Do we still need acpi.h after this change?
Yes, it is still needed as it is using ACPI_PTR.
Cheers, Biju
| |