lkml.org 
[lkml]   [2023]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/4] tracing/filters: Change parse_pred() cpulist ternary into an if block
    Date
    Review comments noted that an if block would be clearer than a ternary, so
    swap it out.

    No change in behaviour intended

    Signed-off-by: Valentin Schneider <vschneid@redhat.com>
    ---
    kernel/trace/trace_events_filter.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
    index eb331e8b00b61..09b4733a2933d 100644
    --- a/kernel/trace/trace_events_filter.c
    +++ b/kernel/trace/trace_events_filter.c
    @@ -1782,13 +1782,17 @@ static int parse_pred(const char *str, void *data,
    FILTER_PRED_FN_CPUMASK;
    } else if (field->filter_type == FILTER_CPU) {
    if (single) {
    - pred->op = pred->op == OP_BAND ? OP_EQ : pred->op;
    + if (pred->op == OP_BAND)
    + pred->op = OP_EQ;
    +
    pred->fn_num = FILTER_PRED_FN_CPU;
    } else {
    pred->fn_num = FILTER_PRED_FN_CPU_CPUMASK;
    }
    } else if (single) {
    - pred->op = pred->op == OP_BAND ? OP_EQ : pred->op;
    + if (pred->op == OP_BAND)
    + pred->op = OP_EQ;
    +
    pred->fn_num = select_comparison_fn(pred->op, field->size, false);
    if (pred->op == OP_NE)
    pred->not = 1;
    --
    2.31.1
    \
     
     \ /
      Last update: 2023-09-01 17:12    [W:4.488 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site