Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 1 Sep 2023 11:22:33 +0200 | Subject | Re: [RFT PATCH] spi: bcm2835: reduce the abuse of the GPIO API |
| |
On Fri, Sep 1, 2023 at 10:55 AM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > I'm not sure this is a good candidate for the GPIOLIB quirks. This is > > the SPI setup callback (which makes me think - I should have used > > gpiod_get(), not devm_gpiod_get() and then put the descriptor in > > .cleanup()) and not probe. It would be great to get some background on > > why this is even needed in the first place. The only reason I see is > > booting the driver with an invalid device-tree that doesn't assign the > > GPIO to the SPI controller. > > Maybe Lukas knows more?
He does! The background can be found here: https://www.spinics.net/lists/linux-gpio/msg36218.html (hm this "spinics" archive should be imported to lore...)
Yours, Linus Walleij
| |