Messages in this thread | | | From | Kevin Hilman <> | Subject | Re: [PATCH V6 4/4] firmware: ti_sci: Introduce system suspend resume support | Date | Wed, 09 Aug 2023 10:37:17 -0700 |
| |
Tony Lindgren <tony@atomide.com> writes:
> * Kevin Hilman <khilman@kernel.org> [230809 00:20]: >> To me, it sounds like you might want to use ->resume_early() or maybe >> ->resume_noirq() in the pinctrl driver for this so that IO isolation can >> be disabled sooner? > > For calls that need to happen just before the SoC is disabled or first > thing on resume path, cpu_cluster_pm_enter() and cpu_cluster_pm_exit() > notifiers work nice and allow distributing the code across the related > SoC specific code and device drivers. See for example the usage in > drivers/irqchip/irq-gic.c for CPU_CLUSTER_PM_ENTER.
Indeed, this is an option too, but for things that already have "full" drivers (e.g. not an irqchip), they already have a full range of PM callbacks, and adding another set of callbacks/notifiers for cpu_pm_* is a bit clunky IMO.
That being said, for things like this IO isolation stuff that is system-wide, and needs to happen very late in suspend (and/or very early in suspend), cpu_pm_ is worth considering if the same cannot be done with the normal PM callbacks.
Kevin
| |