Messages in this thread | | | From | Asmaa Mnebhi <> | Subject | RE: [PATCH v1 1/2] mlxbf-bootctl: Support the large icmc write/read | Date | Wed, 9 Aug 2023 16:13:23 +0000 |
| |
> > + err = kstrtoul(buf, 16, &icm_data); > > + if (err) > > + return err; > > I suggest using define instead of 16. Done. > > + > > + if (((icm_data != 0) && (icm_data < 0x80)) || > > + (icm_data > 0x100000) || (icm_data % 128)) > > + return -EPERM; > > You can remove reduce '()' and I suggest for to use for consistency 128: > Instead of 128 and 0x80 > If ((icm_data > 0 && icm_data < 128) > > Probably consider to use defines also for the above magic. Done.
| |