Messages in this thread | | | Date | Wed, 9 Aug 2023 18:58:15 +0800 | Subject | Re: [PATCH 2/5] iommu: Call helper function to get assigned pasid value | From | Baolu Lu <> |
| |
On 2023/8/9 17:49, Tian, Kevin wrote: >> From: Baolu Lu <baolu.lu@linux.intel.com> >> Sent: Wednesday, August 9, 2023 8:22 AM >> >> On 2023/8/8 15:49, Tina Zhang wrote: >>> Use the helper function mm_get_pasid() to get the mm assigned pasid >>> value. >> >> For internal iommu drivers, perhaps we should use another helper. >> Something like sva_domain_get_pasid()? >> >> Suppose that the iommu drivers should have no idea about the "mm". >> > > Aren't all touched functions accept a struct mm_struct pointer?
In the end we should remove all mm reference in the individual drivers. The drivers only need to know what they need to know. All mm-aware code should eventually be moved to the core.
For now, at least we should avoid using mm in the set/remove_dev_pasid code path. Later, once we complete consolidating mm notification in the core, drivers will have no need to use "mm" anymore.
Best regards, baolu
| |