Messages in this thread | | | From | "Tian, Kevin" <> | Subject | RE: [PATCH 1/5] iommu: Add mm_get_pasid() helper function | Date | Wed, 9 Aug 2023 09:47:15 +0000 |
| |
> From: Jason Gunthorpe <jgg@ziepe.ca> > Sent: Tuesday, August 8, 2023 11:02 PM > > On Tue, Aug 08, 2023 at 03:49:40PM +0800, Tina Zhang wrote: > > mm_get_pasid() is for getting mm pasid value. > > > > The motivation is to replace mm->pasid with an iommu private data > > structure that is introduced in a later patch. > > Maybe we should start out by calling it what it actually is: > > 'mm_get_enqcmd_pasid()' > > We can't actually have multiple SVA domains with different PASIDs > until the places wrongly calling this are removed :\ >
it's kind of egg-chicken problem. mm_get_pasid() is used by all SVA scenarios beyond enqcmd then calling it mm_get_enqcmd_pasid() also sounds weird for non-enqcmd case.
unless you were suggesting to just create a new wrapper for this specific enqcmd path (try_fixup_enqcmd_gp()) then I'm fine. 😊
| |