Messages in this thread | | | From | Peng Fan <> | Subject | RE: [PATCH V6 7/8] firmware: imx: scu-irq: enlarge the IMX_SC_IRQ_NUM_GROUP | Date | Wed, 9 Aug 2023 09:13:24 +0000 |
| |
> Subject: Re: [PATCH V6 7/8] firmware: imx: scu-irq: enlarge the > IMX_SC_IRQ_NUM_GROUP > > On Mon, Aug 7, 2023 at 4:11 PM Peng Fan (OSS) <peng.fan@oss.nxp.com> > wrote: > > > > From: Peng Fan <peng.fan@nxp.com> > > > > Per SCFW update, update the IMX_SC_IRQ_NUM_GROUP to 9. > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > drivers/firmware/imx/imx-scu-irq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/firmware/imx/imx-scu-irq.c > > b/drivers/firmware/imx/imx-scu-irq.c > > index 6549f3792a0f..8d902db1daf2 100644 > > --- a/drivers/firmware/imx/imx-scu-irq.c > > +++ b/drivers/firmware/imx/imx-scu-irq.c > > @@ -14,7 +14,7 @@ > > > > #define IMX_SC_IRQ_FUNC_ENABLE 1 > > #define IMX_SC_IRQ_FUNC_STATUS 2 > > -#define IMX_SC_IRQ_NUM_GROUP 4 > > +#define IMX_SC_IRQ_NUM_GROUP 9 > > This is tricky. Shouldn't we have some sort of versioning so that the user > knows that kernel and scfw are not compatible anymore?
It would not hurt here for scu irq num group. Newer linux could work with older scfw.
But you raised a good point, we could print scfw version when probing scu firmware, and for un compatible case, version check could be used.
Thanks, Peng.
| |