Messages in this thread | | | From | Miguel Ojeda <> | Date | Wed, 9 Aug 2023 11:09:25 +0200 | Subject | Re: [RFC PATCH v1 5/5] rust: file: add `DeferredFdCloser` |
| |
On Wed, Aug 9, 2023 at 11:00 AM Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote: > > If you mean for the commit, then we should follow the kernel > convention instead. Please see my reply to Alice above.
One extra note: if it is a external repository, then yes, I would definitely recommend adding a `Link` because readers may not be able to easily `git show` the hash. But if it is the kernel tree, then it is not needed.
Cheers, Miguel
| |