Messages in this thread Patches in this message | | | From | Joel Stanley <> | Date | Wed, 9 Aug 2023 08:15:51 +0000 | Subject | Re: [PATCH v7 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite 4 BMC |
| |
On Wed, 9 Aug 2023 at 08:12, Joel Stanley <joel@jms.id.au> wrote: > > On Wed, 9 Aug 2023 at 08:05, Joel Stanley <joel@jms.id.au> wrote: > > > > On Tue, 8 Aug 2023 at 08:43, Delphine CC Chiu > > <Delphine_CC_Chiu@wiwynn.com> wrote: > > > > > > Add linux device tree entry related to > > > Yosemite 4 specific devices connected to BMC SoC. > > There were also some of these annoying warnings. Please try to fix > them up in your next version: > > ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:460.4-14: > Warning (reg_format): > /ahb/apb/bus@1e78a000/i2c-bus@780/i2c-mux@71/i2c@0:reg: property has > invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)@@ -450,6 +450,9 @@ eeprom@51 {
This silenced most of them:
i2c-mux@71 { compatible = "nxp,pca9846"; + #address-cells = <1>; + #size-cells = <0>; + idle-state = <0>; i2c-mux-idle-disconnect; reg = <0x71>; @@ -557,6 +560,9 @@ gpio@61 {
i2c-mux@73 { compatible = "nxp,pca9544"; + #address-cells = <1>; + #size-cells = <0>; + idle-state = <0>; i2c-mux-idle-disconnect; reg = <0x73>; And then this fixed the remaining one:
@@ -423,7 +423,7 @@ power-sensor@42 { reg = <0x42>; };
- power-sensor@41 { + power-sensor@43 { compatible = "ti,ina230"; reg = <0x43>; };
Please fold in these changes in your next version.
| |