Messages in this thread | | | Date | Thu, 10 Aug 2023 10:30:28 +0800 | Subject | Re: [PATCH v2 05/12] iommu: Change the return value of dev_iommu_get() | From | Baolu Lu <> |
| |
On 2023/8/10 0:58, Jason Gunthorpe wrote: > On Thu, Jul 27, 2023 at 01:48:30PM +0800, Lu Baolu wrote: >> Make dev_iommu_get() return 0 for success and error numbers for failure. >> This will make the code neat and readable. No functionality changes. >> >> Reviewed-by: Jacob Pan<jacob.jun.pan@linux.intel.com> >> Signed-off-by: Lu Baolu<baolu.lu@linux.intel.com> >> --- >> drivers/iommu/iommu.c | 19 +++++++++++-------- >> 1 file changed, 11 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c >> index 00309f66153b..4ba3bb692993 100644 >> --- a/drivers/iommu/iommu.c >> +++ b/drivers/iommu/iommu.c >> @@ -290,20 +290,20 @@ void iommu_device_unregister(struct iommu_device *iommu) >> } >> EXPORT_SYMBOL_GPL(iommu_device_unregister); > It could probably use a nicer name too? > > iommu_alloc_dev_iommu() ? > > Also with Joerg's current tree we can add a device_lock_assert() to > this function, from what I can tell.
Sure. Will update them in the next version.
Best regards, baolu
| |