Messages in this thread | | | Date | Wed, 9 Aug 2023 22:20:54 +0200 | From | Florian Westphal <> | Subject | Re: [PATCH v2 7/7] netfilter: xtables: refactor deprecated strncpy |
| |
Justin Stitt <justinstitt@google.com> wrote: > Prefer `strscpy_pad` as it's a more robust interface whilst maintaing > zero-padding behavior. > > There may have existed a bug here due to both `tbl->repl.name` and > `info->name` having a size of 32 as defined below: > | #define XT_TABLE_MAXNAMELEN 32 > > This may lead to buffer overreads in some situations -- `strscpy` solves > this by guaranteeing NUL-termination of the dest buffer.
I don't think we need to use _pad here.
| |