lkml.org 
[lkml]   [2023]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3 4/9] ALSA: hda/i915: Allow xe as match for i915_component_master_match
    From


    On 8/7/23 04:00, Maarten Lankhorst wrote:
    > xe is a new driver for intel GPU's that shares the sound related code
    > with i915.
    >
    > Don't allow it to be modprobed though; the module is not upstream yet
    > and we should exclusively use the EPROBE_DEFER mechanism.

    The wording hasn't changed and remains confusing, likely to trigger all
    paranoia triplines. Consider rewording if there's an update.

    > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
    > Reviewed-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
    > Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>

    Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

    > ---
    > sound/hda/hdac_i915.c | 3 ++-
    > 1 file changed, 2 insertions(+), 1 deletion(-)
    >
    > diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c
    > index 961fcd3397f4..12c1f8d93499 100644
    > --- a/sound/hda/hdac_i915.c
    > +++ b/sound/hda/hdac_i915.c
    > @@ -115,7 +115,8 @@ static int i915_component_master_match(struct device *dev, int subcomponent,
    > hdac_pci = to_pci_dev(bus->dev);
    > i915_pci = to_pci_dev(dev);
    >
    > - if (!strcmp(dev->driver->name, "i915") &&
    > + if ((!strcmp(dev->driver->name, "i915") ||
    > + !strcmp(dev->driver->name, "xe")) &&
    > subcomponent == I915_COMPONENT_AUDIO &&
    > connectivity_check(i915_pci, hdac_pci))
    > return 1;

    \
     
     \ /
      Last update: 2023-08-07 16:57    [W:8.917 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site