lkml.org 
[lkml]   [2023]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 29/41] mtd: spi-nor: xilinx: use new macros in S3AN_INFO()
    There won't be any new entries, nor are the entries that much different
    and the very odd page and sector sizes make the new format hard to read.
    Therefore, convert the old S3AN_INFO() macro.

    Signed-off-by: Michael Walle <mwalle@kernel.org>
    ---
    This collides with the atmel flashes and there seems to be a typo in the
    IDs. All this makes me wonder wether we shouldn't deprecate the support
    for this (FPGA configuration) flash.
    ---
    drivers/mtd/spi-nor/xilinx.c | 23 ++++++++++++-----------
    1 file changed, 12 insertions(+), 11 deletions(-)

    diff --git a/drivers/mtd/spi-nor/xilinx.c b/drivers/mtd/spi-nor/xilinx.c
    index 8d4539e32dfe..f99118c691b0 100644
    --- a/drivers/mtd/spi-nor/xilinx.c
    +++ b/drivers/mtd/spi-nor/xilinx.c
    @@ -21,21 +21,22 @@
    SPI_MEM_OP_NO_DUMMY, \
    SPI_MEM_OP_DATA_IN(1, buf, 0))

    -#define S3AN_INFO(_jedec_id, _n_sectors, _page_size) \
    - SPI_NOR_ID(_jedec_id, 0), \
    - .size = 8 * (_page_size) * (_n_sectors), \
    - .sector_size = (8 * (_page_size)), \
    - .page_size = (_page_size), \
    - .flags = SPI_NOR_NO_FR
    +#define S3AN_FLASH(_id, _name, _n_sectors, _page_size) \
    + .id = _id, \
    + .name = _name, \
    + .size = 8 * (_page_size) * (_n_sectors), \
    + .sector_size = (8 * (_page_size)), \
    + .page_size = (_page_size), \
    + .flags = SPI_NOR_NO_FR

    /* Xilinx S3AN share MFR with Atmel SPI NOR */
    static const struct flash_info xilinx_nor_parts[] = {
    /* Xilinx S3AN Internal Flash */
    - { "3S50AN", S3AN_INFO(0x1f2200, 64, 264) },
    - { "3S200AN", S3AN_INFO(0x1f2400, 256, 264) },
    - { "3S400AN", S3AN_INFO(0x1f2400, 256, 264) },
    - { "3S700AN", S3AN_INFO(0x1f2500, 512, 264) },
    - { "3S1400AN", S3AN_INFO(0x1f2600, 512, 528) },
    + { S3AN_FLASH(SNOR_ID(0x1f, 0x22, 0x00), "3S50AN", 64, 264) },
    + { S3AN_FLASH(SNOR_ID(0x1f, 0x24, 0x00), "3S200AN", 256, 264) },
    + { S3AN_FLASH(SNOR_ID(0x1f, 0x24, 0x00), "3S400AN", 256, 264) },
    + { S3AN_FLASH(SNOR_ID(0x1f, 0x25, 0x00), "3S700AN", 512, 264) },
    + { S3AN_FLASH(SNOR_ID(0x1f, 0x26, 0x00), "3S1400AN", 512, 528) },
    };

    /*
    --
    2.39.2

    \
     
     \ /
      Last update: 2023-08-07 15:25    [W:3.622 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site