Messages in this thread | | | From | Alexandru Ardelean <> | Date | Mon, 7 Aug 2023 15:00:30 +0300 | Subject | Re: [PATCH] reset: zynq: remove unneeded call to platfrom_set_drvdata() |
| |
On Mon, Aug 7, 2023 at 2:35 PM Andrei Coardos <aboutphysycs@gmail.com> wrote: > > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. >
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> > --- > drivers/reset/reset-zynq.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/reset/reset-zynq.c b/drivers/reset/reset-zynq.c > index 706bbbbb4ec7..688b512882ec 100644 > --- a/drivers/reset/reset-zynq.c > +++ b/drivers/reset/reset-zynq.c > @@ -94,7 +94,6 @@ static int zynq_reset_probe(struct platform_device *pdev) > priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); > if (!priv) > return -ENOMEM; > - platform_set_drvdata(pdev, priv); > > priv->slcr = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, > "syscon"); > -- > 2.34.1 >
| |