Messages in this thread | | | Date | Mon, 7 Aug 2023 10:24:02 +0100 | Subject | Re: [PATCH v6 3/7] perf jevents: Support more event fields | From | John Garry <> |
| |
On 07/08/2023 08:51, Jing Zhang wrote: > The usual event descriptions are "event=xxx" or "config=xxx", while the > event descriptions of CMN are "type=xxx, eventid=xxx" or more complex. > > $cat /sys/bus/event_source/devices/arm_cmn_0/events/hnf_cache_fill > type=0x5,eventid=0x3 > > When adding aliases for events described as "event=xxx" or "config=xxx", > EventCode or ConfigCode can be used in the JSON files to describe the > events. But "eventid=xxx, type=xxx" cannot be supported at present. > > If EventCode and ConfigCode is not added in the alias JSON file, the > event description will add "event=0" by default. So, even if the event > field is added to supplement "eventid=xxx" and "type=xxx", the final > parsing result will be "event=0, eventid=xxx, type=xxx". > > Therefore, when EventCode and ConfigCode are missing in JSON, "event=0" is > no longer added by default. EventIdCode and Type are added to the event > field, and ConfigCode is moved into the event_field array which can also > guarantee its original function. > > Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
I'll let Ian check this change as he is more familiar with this code.
Thanks
| |