Messages in this thread | | | Date | Mon, 7 Aug 2023 19:41:49 -0300 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v4 6/8] iommu/arm-smmu-v3: Move CD table to arm_smmu_master |
| |
On Mon, Aug 07, 2023 at 08:19:44PM +0800, Michael Shavit wrote: > On Fri, Aug 4, 2023 at 2:47 AM Jason Gunthorpe <jgg@nvidia.com> wrote: > > > > > > I'm not surprised, I think arm_smmu_write_ctx is a little too clever > > for its own good.. > > > > I would have written it by computing the full target CD entry, > > extracted directly from the domain. > > > > Yeah I was considering making a fix to arm_smmu_write_ctx instead; but > clearing the CD entry on detach feels like the right thing to do. > Relying on the 0th CD entry being re-written when the CD table is > re-inserted feels fragile. > > Perhaps re-writing arm_smmu_write_ctx could be considered as a > separate singleton patch?
I wouldn't touch it in this series at least
Jason
| |