lkml.org 
[lkml]   [2023]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/9] arm64: dts: qcom: sa8775p: add a node for the second serdes PHY
> That wording of "match downstream sources" is amiguous, sorry.
>
> What I meant was that:
>
> 1. This looks like a properly formatted dtsi node, follows
> conventions in the file for ordering, etc
> 2. The downstream devicetree from Qualcomm uses the same MMIO region
> same dependencies for clocks, etc. I do not have documentation
> to further review past that

O.K. This does make your reviews worthwhile.

Vendor crap gets that name for a reason. So just saying it is the same
as the vendor code is not really helpful. So i would avoid this
ambiguous statement. And your later comment on a patch which points
out real problems adds to my confidence you did a real review.

Thanks
Andrew

\
 
 \ /
  Last update: 2023-08-07 23:49    [W:0.049 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site