lkml.org 
[lkml]   [2023]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch V3 26/60] x86/apic/32: Decrapify the def_bigsmp mechanism
Date
On Mon, Aug 07 2023 at 13:11, Dave Hansen wrote:

> On 8/1/23 03:47, Thomas Gleixner wrote:
> ...
>> -void __init default_setup_apic_routing(void)
>> +void __init x86_32_probe_bigsmp_early(void)
>> {
>> - int version = boot_cpu_apic_version;
>> + if (nr_cpu_ids <= 8 || xen_pv_domain())
>> + return;
> ...
>> +void __init default_setup_apic_routing(void)
>> +{
>> + if (nr_cpu_ids >= 8 && !xen_pv_domain())
>> + apic_bigsmp_force();
>
> I thought bigsmp didn't come into play until 9 or more CPUs. Won't this
> do apic_bigsmp_force() at nr_cpu_ids==8?
>
> Should this be:
>
> if (nr_cpu_ids > 8 && !xen_pv_domain())
> apic_bigsmp_force();
>
> ?

Yes, obviously. Thanks for catching that

\
 
 \ /
  Last update: 2023-08-07 23:19    [W:0.058 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site