Messages in this thread | | | From | Sai Krishna Gajula <> | Subject | Re: [net-next PATCH] octeontx2-pf: Use PTP HW timestamp counter atomic update feature | Date | Mon, 7 Aug 2023 06:41:22 +0000 |
| |
> -----Original Message----- > From: Simon Horman <horms@kernel.org> > Sent: Saturday, August 5, 2023 5:04 PM > To: Sai Krishna Gajula <saikrishnag@marvell.com> > Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org; > pabeni@redhat.com; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; Sunil Kovvuri Goutham <sgoutham@marvell.com>; > Geethasowjanya Akula <gakula@marvell.com>; Subbaraya Sundeep Bhatta > <sbhatta@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>; > richardcochran@gmail.com; Naveen Mamindlapalli > <naveenm@marvell.com> > Subject: Re: [net-next PATCH] octeontx2-pf: Use PTP HW timestamp > counter atomic update feature > > On Fri, Aug 04, 2023 at 03:00:14PM +0530, Sai Krishna wrote: > > Some of the newer silicon versions in CN10K series supports a feature > > where in the current PTP timestamp in HW can be updated atomically > > without losing any cpu cycles unlike read/modify/write register. > > This patch uses this feature so that PTP accuracy can be improved > > while adjusting the master offset in HW. There is no need for SW > > timecounter when using this feature. So removed references to SW > > timecounter wherever appropriate. > > > > Signed-off-by: Sai Krishna <saikrishnag@marvell.com> > > Signed-off-by: Naveen Mamindlapalli <naveenm@marvell.com> > > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com> > > ... > > > struct npc_get_field_status_req { > > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/ptp.c > > b/drivers/net/ethernet/marvell/octeontx2/af/ptp.c > > ... > > > > > -static bool is_ptp_tsfmt_sec_nsec(struct ptp *ptp) > > +static inline bool is_tstmp_atomic_update_supported(struct rvu *rvu) > > Hi Sai, > > Please avoid using the inline keyword for functions in .c files. > Unless there is a demonstrable advantage to doing so it should be left up to > the compiler to inline or not.
Ok, will remove inline keyword and submit V2 patch.
Thanks, Sai > > ... > > -- > pw-bot: changes-requested
| |