lkml.org 
[lkml]   [2023]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 04/10] drm/panel_helper: Introduce drm_panel_helper
    Hi Doug,

    Thanks for working on this :)

    On Fri, Aug 04, 2023 at 02:06:07PM -0700, Douglas Anderson wrote:
    > The goal of this file is to contain helper functions for panel drivers
    > to use. To start off with, let's add drm_panel_helper_shutdown() for
    > use by panels that want to make sure they're powered off at
    > shutdown/remove time if they happen to be powered on.
    >
    > The main goal of introducting this function is so that panel drivers
    > don't need to track the enabled/prepared state themselves.
    >
    > Signed-off-by: Douglas Anderson <dianders@chromium.org>

    It shouldn't be necessary at all: drivers should call
    drm_atomic_helper_shutdown at removal time which will disable the
    connector (which in turn should unprepare/disable its panel).

    If either the driver is missing drm_atomic_helper_shutdown, or if the
    connector doesn't properly disable the panel, then I would consider that
    a bug.

    Maxime
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2023-08-07 08:42    [W:6.194 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site