Messages in this thread | | | From | Adam Ford <> | Date | Sun, 6 Aug 2023 17:20:17 -0500 | Subject | Re: [PATCH] arm64: dts: imx8mp-beacon: Configure 100MHz PCIe Ref Clk |
| |
On Sun, Aug 6, 2023 at 5:03 PM Fabio Estevam <festevam@gmail.com> wrote: > > Hi Adam, > > On Sun, Aug 6, 2023 at 4:06 PM Adam Ford <aford173@gmail.com> wrote: > > > &pcie_phy { > > + fsl,clkreq-unsupported; > > fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>; > > - clocks = <&pcie0_refclk>; > > Should the pcie0_refclk node be also removed? It seems to be unused > after this patch.
Oops, you're right. I will send a V2.
> > > + clocks = <&pcieclk 1>; > > Isn't clocks = <&pcieclk>; (without the extra 1) enough?
The clock generator has two outputs called DIF0 and DIF1. This hardware uses DIF1 for the reference clock, so I need to specify output 1.
adam
| |