Messages in this thread | | | From | Miguel Ojeda <> | Date | Sat, 5 Aug 2023 12:46:18 +0200 | Subject | Re: [PATCH v3] scripts: generate_rust_analyzer: provide `cfg`s for `core` and `alloc` |
| |
On Fri, Aug 4, 2023 at 7:14 PM Martin Rodriguez Reboredo <yakoyoku@gmail.com> wrote: > > Suggested-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Thanks Martin!
I am a bit confused about the Suggested-by -- did you add it due to the suggestion from v1 of passing variables via command-line arguments? If so, I appreciate the gesture, but the main idea/report (passing the missing `cfg`s for `core` and `alloc`) is yours! :)
The patch seems fine, I will test & apply it soon. If someone wants to give it a Tested-by with rust-analyzer, that would be great too, thanks! (note: it applies on top of `rust-next`).
Cheers, Miguel
| |