Messages in this thread Patch in this message | | | Date | Sun, 6 Aug 2023 10:05:53 +0800 | Subject | Re: [PATCH 1/1] f2fs: move fiemap to use iomap framework | From | Chao Yu <> |
| |
On 2023/7/31 9:26, Wu Bo wrote: > This patch has been tested with xfstests by running 'kvm-xfstests -c > f2fs -g auto' with and without this patch; no regressions were seen. > > Some tests fail both before and after, and the test results are: > f2fs/default: 683 tests, 9 failures, 226 skipped, 30297 seconds > Failures: generic/050 generic/064 generic/250 generic/252 generic/459 > generic/506 generic/563 generic/634 generic/635
Can you please take a look at gerneic/473 ?
generic/473 1s ... - output mismatch (see /media/fstests/results//generic/473.out.bad) --- tests/generic/473.out 2022-11-10 08:42:19.231395230 +0000 +++ /media/fstests/results//generic/473.out.bad 2023-08-04 02:02:01.000000000 +0000 @@ -6,7 +6,7 @@ 1: [256..287]: hole Hole + Data 0: [0..127]: hole -1: [128..255]: data +1: [128..135]: data Hole + Data + Hole 0: [0..127]: hole ... (Run 'diff -u /media/fstests/tests/generic/473.out /media/fstests/results//generic/473.out.bad' to see the entire diff) Other concern is, it needs to test this implementation on compressed file, since the logic is a little bit complicated.
+Cc Daeho Jeong
Thanks,
| |