Messages in this thread | | | Date | Sat, 5 Aug 2023 17:47:06 -0400 | Subject | Re: [PATCH] zram: take device and not only bvec offset into account | From | Dusty Mabe <> |
| |
On 8/5/23 04:13, Christoph Hellwig wrote: > On Sat, Aug 05, 2023 at 04:46:45PM +0900, Sergey Senozhatsky wrote: >>> Fixes: af8b04c63708 ("zram: simplify bvec iteration in __zram_make_request") >>> Reported-by: Dusty Mabe <dusty@dustymabe.com> >>> Signed-off-by: Christoph Hellwig <hch@lst.de> >> >> Acked-by: Sergey Senozhatsky <senozhatsky@chromium.org> > > Btw, are there any interesting test suites you want me to run on > a > 4K page size system now that I do have this setup available?
The patch is passing tests for me. I ran the Fedora CoreOS root reprovision tests (which are the tests that caught this bug to begin with) and the trivial reproducer:
``` #!/bin/bash set -eux -o pipefail modprobe zram num_devices=0 read dev < /sys/class/zram-control/hot_add echo 10G > /sys/block/zram"${dev}"/disksize mkfs.xfs /dev/zram"${dev}" mkdir -p /tmp/foo mount -t xfs /dev/zram"${dev}" /tmp/foo ```
Dusty
| |