Messages in this thread | | | Date | Fri, 4 Aug 2023 12:55:34 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v1 1/4] lib/vsprintf: Declare no_hash_pointers in a local header |
| |
On Fri, 4 Aug 2023 10:38:22 +0200 Marco Elver <elver@google.com> wrote:
> > +++ b/lib/vsprintf.h > > @@ -0,0 +1,7 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#ifndef _LIB_VSPRINTF_H > > +#define _LIB_VSPRINTF_H > > + > > +extern bool no_hash_pointers; > > + > > +#endif > > It seems odd to create such a local header and then refer to it from > other subsystems. > > What's the downside of just putting this into the new > include/linux/sprintf.h? If someone wants to access this variable, > they will one way or another.
+1
-- Steve
| |