lkml.org 
[lkml]   [2023]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/4] lib/vsprintf: Declare no_hash_pointers in a local header
On Fri, 4 Aug 2023 10:38:22 +0200
Marco Elver <elver@google.com> wrote:

> > +++ b/lib/vsprintf.h
> > @@ -0,0 +1,7 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +#ifndef _LIB_VSPRINTF_H
> > +#define _LIB_VSPRINTF_H
> > +
> > +extern bool no_hash_pointers;
> > +
> > +#endif
>
> It seems odd to create such a local header and then refer to it from
> other subsystems.
>
> What's the downside of just putting this into the new
> include/linux/sprintf.h? If someone wants to access this variable,
> they will one way or another.

+1

-- Steve

\
 
 \ /
  Last update: 2023-08-04 18:56    [W:0.032 / U:0.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site