Messages in this thread | | | Date | Fri, 4 Aug 2023 16:54:03 +0200 | From | Christian Brauner <> | Subject | Re: [PATCH v9 04/12] ceph: add enable_unsafe_idmap module parameter |
| |
On Fri, Aug 04, 2023 at 10:48:50AM +0200, Alexander Mikhalitsyn wrote: > This parameter is used to decide if we allow > to perform IO on idmapped mount in case when MDS lacks > support of CEPHFS_FEATURE_HAS_OWNER_UIDGID feature. > > In this case we can't properly handle MDS permission > checks and if UID/GID-based restrictions are enabled > on the MDS side then IO requests which go through an > idmapped mount may fail with -EACCESS/-EPERM. > Fortunately, for most of users it's not a case and > everything should work fine. But we put work "unsafe" > in the module parameter name to warn users about > possible problems with this feature and encourage > update of cephfs MDS. > > Cc: Xiubo Li <xiubli@redhat.com> > Cc: Jeff Layton <jlayton@kernel.org> > Cc: Ilya Dryomov <idryomov@gmail.com> > Cc: ceph-devel@vger.kernel.org > Suggested-by: Stéphane Graber <stgraber@ubuntu.com> > Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com> > ---
Seems good enough, Acked-by: Christian Brauner <brauner@kernel.org>
| |