Messages in this thread | | | Date | Fri, 4 Aug 2023 16:42:09 +0200 | Subject | Re: [PATCH] extcon: cht_wc: add POWER_SUPPLY dependency | From | Hans de Goede <> |
| |
Hi,
On 8/4/23 15:28, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The driver fails to link when CONFIG_POWER_SUPPLY is disabled: > > x86_64-linux-ld: vmlinux.o: in function `cht_wc_extcon_psy_get_prop': > extcon-intel-cht-wc.c:(.text+0x15ccda7): undefined reference to `power_supply_get_drvdata' > x86_64-linux-ld: vmlinux.o: in function `cht_wc_extcon_pwrsrc_event': > extcon-intel-cht-wc.c:(.text+0x15cd3e9): undefined reference to `power_supply_changed' > x86_64-linux-ld: vmlinux.o: in function `cht_wc_extcon_probe': > extcon-intel-cht-wc.c:(.text+0x15cd596): undefined reference to `devm_power_supply_register' > > It should be possible to change the driver to not require this at > compile time and still provide other functions, but adding a hard > Kconfig dependency does not seem to have any practical downsides > and is simpler since the option is normally enabled anyway. > > Fixes: 66e31186cd2aa ("extcon: intel-cht-wc: Add support for registering a power_supply class-device") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> --- > drivers/extcon/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig > index 0ef1971d22bb0..8de9023c2a387 100644 > --- a/drivers/extcon/Kconfig > +++ b/drivers/extcon/Kconfig > @@ -62,6 +62,7 @@ config EXTCON_INTEL_CHT_WC > tristate "Intel Cherrytrail Whiskey Cove PMIC extcon driver" > depends on INTEL_SOC_PMIC_CHTWC > depends on USB_SUPPORT > + depends on POWER_SUPPLY > select USB_ROLE_SWITCH > help > Say Y here to enable extcon support for charger detection / control
| |