lkml.org 
[lkml]   [2023]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next v3 0/6] page_pool: a couple of assorted optimizations
From
From: Jakub Kicinski <kuba@kernel.org>
Date: Thu, 3 Aug 2023 18:21:21 -0700

> On Thu, 3 Aug 2023 20:20:32 +0200 Alexander Lobakin wrote:
>> That initially was a spin-off of the IAVF PP series[0], but has grown
>> (and shrunk) since then a bunch. In fact, it consists of three
>> semi-independent blocks:
>>
>> * #1-2: Compile-time optimization. Split page_pool.h into 2 headers to
>> not overbloat the consumers not needing complex inline helpers and
>> then stop including it in skbuff.h at all. The first patch is also
>> prereq for the whole series.
>> * #3: Improve cacheline locality for users of the Page Pool frag API.
>> * #4-6: Use direct cache recycling more aggressively, when it is safe
>> obviously. In addition, make sure nobody wants to use Page Pool API
>> with disabled interrupts.
>>
>> Patches #1 and #5 are authored by Yunsheng and Jakub respectively, with
>> small modifications from my side as per ML discussions.
>> For the perf numbers for #3-6, please see individual commit messages.
>
> Our scheming didn't help much, the series also conflicts
> with the net/xdp.h includes which came in via bpf-next :(

Haha that happens. I rechecked everything before sending, but well, we
need a spinlock or what :D
I'll send v4 in a couple hours, so that ~22 hrs will pass since v3,
sounds okay?

Thanks,
Olek

\
 
 \ /
  Last update: 2023-08-04 16:32    [W:0.107 / U:1.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site