Messages in this thread | | | Date | Fri, 4 Aug 2023 11:57:08 +0530 | Subject | Re: [PATCH 2/4] net: ti: icss-iep: Add IEP driver | From | Md Danish Anwar <> |
| |
On 03/08/23 8:46 pm, Simon Horman wrote: > On Thu, Aug 03, 2023 at 04:31:51PM +0530, MD Danish Anwar wrote: >> From: Roger Quadros <rogerq@ti.com> >> >> Add a driver for Industrial Ethernet Peripheral (IEP) block of PRUSS to >> support timestamping of ethernet packets and thus support PTP and PPS >> for PRU ethernet ports. >> >> Signed-off-by: Roger Quadros <rogerq@ti.com> >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> >> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com> >> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> >> Signed-off-by: MD Danish Anwar <danishanwar@ti.com> > > ... > >> +static int icss_iep_pps_enable(struct icss_iep *iep, int on) >> +{ >> + int ret = 0; >> + struct timespec64 ts; >> + struct ptp_clock_request rq; >> + unsigned long flags; >> + u64 ns; > > For networking code, please arrange local variables in reverse xmas tree > order - longest line to shortest. > > https://github.com/ecree-solarflare/xmastree is your friend here. > > ...
Sure Simon, I will take care of this in next revision.
-- Thanks and Regards, Danish.
| |