Messages in this thread Patch in this message | | | From | Arnd Bergmann <> | Subject | [PATCH 2/2] watchdog/hardlockup: simplify Kconfig selection | Date | Fri, 4 Aug 2023 15:27:51 +0200 |
| |
From: Arnd Bergmann <arnd@arndb.de>
The use of the 'imply' keyword tends to be a bad idea, as it's at best confusing to the reader but often actually doesn't do what the author intended.
In this case, it seems to be used correctly, but doing the same thing using 'default' statements as we have elsewhere in the kernel is simpler and would be easier to understand by readers that are unfamiliar with the special semantics of 'imply'.
Fixes: 1356d0b966e7e ("watchdog/hardlockup: make the config checks more straightforward") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- I got confused by the 'imply' here myself and thought this had caused a build failure that turned out to be unrelated, but it might help to apply this anyway to save the next person the confusion. --- lib/Kconfig.debug | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 72177a80baddc..8cfb49b6974c8 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1056,9 +1056,6 @@ config HARDLOCKUP_DETECTOR bool "Detect Hard Lockups" depends on DEBUG_KERNEL && !S390 && !HARDLOCKUP_DETECTOR_SPARC64 depends on HAVE_HARDLOCKUP_DETECTOR_PERF || HAVE_HARDLOCKUP_DETECTOR_BUDDY || HAVE_HARDLOCKUP_DETECTOR_ARCH - imply HARDLOCKUP_DETECTOR_PERF - imply HARDLOCKUP_DETECTOR_BUDDY - imply HARDLOCKUP_DETECTOR_ARCH select LOCKUP_DETECTOR help @@ -1090,24 +1087,21 @@ config HARDLOCKUP_DETECTOR_PREFER_BUDDY for the hardlockup detector are better used for other things. config HARDLOCKUP_DETECTOR_PERF - bool + def_bool HAVE_HARDLOCKUP_DETECTOR_PERF depends on HARDLOCKUP_DETECTOR - depends on HAVE_HARDLOCKUP_DETECTOR_PERF && !HARDLOCKUP_DETECTOR_PREFER_BUDDY - depends on !HAVE_HARDLOCKUP_DETECTOR_ARCH + depends on !HARDLOCKUP_DETECTOR_PREFER_BUDDY && !HAVE_HARDLOCKUP_DETECTOR_ARCH select HARDLOCKUP_DETECTOR_COUNTS_HRTIMER config HARDLOCKUP_DETECTOR_BUDDY - bool + def_bool HAVE_HARDLOCKUP_DETECTOR_BUDDY depends on HARDLOCKUP_DETECTOR - depends on HAVE_HARDLOCKUP_DETECTOR_BUDDY depends on !HAVE_HARDLOCKUP_DETECTOR_PERF || HARDLOCKUP_DETECTOR_PREFER_BUDDY depends on !HAVE_HARDLOCKUP_DETECTOR_ARCH select HARDLOCKUP_DETECTOR_COUNTS_HRTIMER config HARDLOCKUP_DETECTOR_ARCH - bool + def_bool HAVE_HARDLOCKUP_DETECTOR_ARCH depends on HARDLOCKUP_DETECTOR - depends on HAVE_HARDLOCKUP_DETECTOR_ARCH help The arch-specific implementation of the hardlockup detector will be used. -- 2.39.2
| |