Messages in this thread | | | Date | Fri, 4 Aug 2023 14:38:35 +0200 | From | "" <> | Subject | Re: [PATCH] usb: dwc3: gadget: Let pm runtime get/put paired |
| |
On Tue, Aug 01, 2023 at 11:56:26PM +0000, Thinh Nguyen wrote: > On Tue, Aug 01, 2023, gregkh@linuxfoundation.org wrote: > > On Tue, Aug 01, 2023 at 12:49:24AM +0000, Thinh Nguyen wrote: > > > Hi, > > > > > > On Mon, Jul 31, 2023, Surong Pang wrote: > > > > Pm_runtime_get is called when setting pending_events to true. > > > > Pm_runtime_put is needed for pairing with pm_runtime_get. > > > > > > > > Fixes: fc8bb91bc83ef ("usb: dwc3: implement runtime PM") > > > > > > Please fix your Fixes tag. Run checkpatch.pl before submit. > > > > I don't see what's wrong with it, one extra character is just fine. > > > > This inconsistency bugs me a bit. :) > > It's noted in the kernel documentation that it should be tagged with the > first 12 char of the commit id, and the checkpatch also complaints when > it's not.
Fair enough, consistency is good.
greg k-h
| |