lkml.org 
[lkml]   [2023]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] romfs: only select BUFFER_HEAD for the block based path
From
Hi Christoph,

On 2023/8/4 18:26, Christoph Hellwig wrote:
> selecting BUFFER_HEAD unconditionally does not work as romfs can also
> be built with only the MTD backend and thus without CONFIG_BLOCK.
>
> Fixes: 0f842210d97a ("fs/Kconfig: Fix compile error for romfs")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/romfs/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/romfs/Kconfig b/fs/romfs/Kconfig
> index 3f6b550eee6192..f24a96a331af1b 100644
> --- a/fs/romfs/Kconfig
> +++ b/fs/romfs/Kconfig
> @@ -2,7 +2,6 @@
> config ROMFS_FS
> tristate "ROM file system support"
> depends on BLOCK || MTD
> - select BUFFER_HEAD
> help
> This is a very small read-only file system mainly intended for
> initial ram disks of installation disks, but it could be used for
> @@ -58,6 +57,7 @@ endchoice
> config ROMFS_ON_BLOCK
> bool
> default y if ROMFS_BACKED_BY_BLOCK || ROMFS_BACKED_BY_BOTH
> + select BUFFER_HEAD
>
> config ROMFS_ON_MTD
> bool

I have tested the patch on my environment and it resolves the two
compile errors reported by kernel test robot. The links are as follows:

Link1:
https://lore.kernel.org/oe-kbuild-all/202308031810.pQzGmR1v-lkp@intel.com/
Link2:
https://lore.kernel.org/oe-kbuild-all/202308041329.6SK97Asr-lkp@intel.com/

Tested-by: Li Zetao <lizetao1@huawei.com>

Thanks,
Li Zetao

\
 
 \ /
  Last update: 2023-08-04 13:00    [W:0.036 / U:0.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site