Messages in this thread | | | Date | Fri, 4 Aug 2023 10:27:32 +0200 | From | Neil Armstrong <> | Subject | Re: [PATCH] Revert "drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet" |
| |
On 02/08/2023 11:08, Dmitry Baryshkov wrote: > On Wed, 2 Aug 2023 at 11:52, Neil Armstrong <neil.armstrong@linaro.org> wrote: >> >> This reverts commit [1] to fix display regression on the Dragonboard 845c >> (SDM845) devboard. >> >> There's a mismatch on the real action of the following flags: >> - MIPI_DSI_MODE_VIDEO_NO_HSA >> - MIPI_DSI_MODE_VIDEO_NO_HFP >> - MIPI_DSI_MODE_VIDEO_NO_HBP >> which leads to a non-working display on qcom platforms. >> >> [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet") > > Nit: I think the preferred form is to write `... reverts commit abcdef > ("foo and bar")', but I might be wrong.
Yep, I'll fix all that while applying.
Thanks, Neil
> > Other than that: > > Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > >> >> Cc: Marek Vasut <marex@denx.de> >> Cc: Robert Foss <rfoss@kernel.org> >> Cc: Jagan Teki <jagan@amarulasolutions.com> >> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> >> Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet") >> Reported-by: Amit Pundir <amit.pundir@linaro.org> >> Link: https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> drivers/gpu/drm/bridge/lontium-lt9611.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c >> index 5163e5224aad..9663601ce098 100644 >> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c >> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c >> @@ -774,9 +774,7 @@ static struct mipi_dsi_device *lt9611_attach_dsi(struct lt9611 *lt9611, >> dsi->lanes = 4; >> dsi->format = MIPI_DSI_FMT_RGB888; >> dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | >> - MIPI_DSI_MODE_VIDEO_HSE | MIPI_DSI_MODE_VIDEO_NO_HSA | >> - MIPI_DSI_MODE_VIDEO_NO_HFP | MIPI_DSI_MODE_VIDEO_NO_HBP | >> - MIPI_DSI_MODE_NO_EOT_PACKET; >> + MIPI_DSI_MODE_VIDEO_HSE; >> >> ret = devm_mipi_dsi_attach(dev, dsi); >> if (ret < 0) { >> >> --- >> base-commit: f590814603bf2dd8620584b7d59ae94d7c186c69 >> change-id: 20230802-revert-do-not-generate-hfp-hbp-hsa-eot-packet-6f042b1ba813 >> >> Best regards, >> -- >> Neil Armstrong <neil.armstrong@linaro.org> >> > >
| |