Messages in this thread | | | Date | Thu, 3 Aug 2023 21:38:02 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v5 3/3] serial: core: Fix serial core controller port name to show controller id |
| |
On 8/3/23 21:20, Andy Shevchenko wrote: > On Thu, Aug 03, 2023 at 03:18:42PM -0700, Guenter Roeck wrote: >> On Tue, Jul 25, 2023 at 08:42:12AM +0300, Tony Lindgren wrote: >>> We are missing the serial core controller id for the serial core port >>> name. Let's fix the issue for sane sysfs output, and to avoid issues >>> addressing serial ports later on. >>> >>> And as we're now showing the controller id, the "ctrl" and "port" prefix >>> for the DEVNAME become useless, we can just drop them. Let's standardize on >>> DEVNAME:0 for controller name, where 0 is the controller id. And >>> DEVNAME:0.0 for port name, where 0.0 are the controller id and port id. >>> >>> This makes the sysfs output nicer, on qemu for example: >>> >>> $ ls /sys/bus/serial-base/devices >>> 00:04:0 serial8250:0 serial8250:0.2 >>> 00:04:0.0 serial8250:0.1 serial8250:0.3 >>> >>> Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM") >>> Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >>> Signed-off-by: Tony Lindgren <tony@atomide.com> >> >> This patch causes about 50% of my boot tests to fail because the console >> is no longer recognized. Reverting this patch fixes the problem. >> Bisect log attached. > > Isn't fix already available? > 7d695d83767c ("serial: core: Fix serial_base_match() after fixing controller port name") >
Yes, hopefully that should fix it. We'll see tonight, when my test bed builds it again.
Guenter
| |