Messages in this thread | | | Date | Fri, 4 Aug 2023 09:50:59 +0200 | From | Michal Hocko <> | Subject | Re: [PATCH v3 2/2] watchdog/hardlockup: Avoid large stack frames in watchdog_hardlockup_check() |
| |
On Thu 03-08-23 16:07:58, Douglas Anderson wrote: > After commit 77c12fc95980 ("watchdog/hardlockup: add a "cpu" param to > watchdog_hardlockup_check()") we started storing a `struct cpumask` on > the stack in watchdog_hardlockup_check(). On systems with > CONFIG_NR_CPUS set to 8192 this takes up 1K on the stack. That > triggers warnings with `CONFIG_FRAME_WARN` set to 1024. > > We'll use the new trigger_allbutcpu_cpu_backtrace() to avoid needing > to use a CPU mask at all. > > Fixes: 77c12fc95980 ("watchdog/hardlockup: add a "cpu" param to watchdog_hardlockup_check()") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/r/202307310955.pLZDhpnl-lkp@intel.com > Signed-off-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Michal Hocko <mhocko@suse.com>
Thanks! -- Michal Hocko SUSE Labs
| |