Messages in this thread | | | Date | Fri, 4 Aug 2023 23:56:31 +0200 | From | Andi Shyti <> | Subject | Re: [PATCH] i2c: tegra: Fix i2c-tegra DMA config option processing |
| |
BTW...
On Thu, Aug 03, 2023 at 05:10:02PM +0000, Parker Newman wrote: >
you have a blank line here.
> This patch fixes the Tegra DMA config option processing in the > i2c-tegra driver. > > Tegra processors prior to Tegra186 used APB DMA for I2C requiring > CONFIG_TEGRA20_APB_DMA=y while Tegra186 and later use GPC DMA requiring > CONFIG_TEGRA186_GPC_DMA=y. > > The check for if the processor uses APB DMA is inverted and so the wrong > DMA config options are checked. > > This means if CONFIG_TEGRA20_APB_DMA=y but CONFIG_TEGRA186_GPC_DMA=n > with a Tegra186 or later processor the driver will incorrectly think DMA is > enabled and attempt to request DMA channels that will never be availible, > leaving the driver in a perpetual EPROBE_DEFER state. > > Signed-off-by: Parker Newman <pnewman@connecttech.com>
As this is a fix you also need to add
Fixes: 48cb6356fae1 ("i2c: tegra: Add GPCDMA support") Cc: Akhil R <akhilrajeev@nvidia.com> Cc: <stable@vger.kernel.org> # v6.1+
Cc'eing Akhil as well for his opinion on this.
Andi
| |