Messages in this thread | | | Date | Fri, 4 Aug 2023 22:46:24 +0200 | From | Simon Horman <> | Subject | Re: [RFC Optimizing veth xsk performance 04/10] xsk: add xsk_tx_completed_addr function |
| |
On Thu, Aug 03, 2023 at 10:04:30PM +0800, huangjie.albert wrote:
...
> index 13354a1e4280..a494d1dcb1c3 100644 > --- a/net/xdp/xsk_queue.h > +++ b/net/xdp/xsk_queue.h > @@ -428,6 +428,17 @@ static inline void __xskq_prod_submit(struct xsk_queue *q, u32 idx) > smp_store_release(&q->ring->producer, idx); /* B, matches C */ > } > > +
nit: one blank line is enough
> +static inline void xskq_prod_submit_addr(struct xsk_queue *q, u64 addr) > +{ > + struct xdp_umem_ring *ring = (struct xdp_umem_ring *)q->ring; > + u32 idx = q->ring->producer; > + > + ring->desc[idx++ & q->ring_mask] = addr; > + > + __xskq_prod_submit(q, idx); > +} > + > static inline void xskq_prod_submit(struct xsk_queue *q) > { > __xskq_prod_submit(q, q->cached_prod); > -- > 2.20.1 > >
| |