Messages in this thread | | | Date | Fri, 4 Aug 2023 23:34:03 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 4/4] lib/vsprintf: Split out sprintf() and friends |
| |
On Fri, Aug 04, 2023 at 11:31:58AM +0200, Rasmus Villemoes wrote: > On 04/08/2023 10.26, Andy Shevchenko wrote:
...
> > +#include <linux/types.h> > > Shouldn't this at least also include compiler_attributes.h, to make it > self-contained?
As I replied in the other email, this is guaranteed by types.h. But if you insist, I can add it.
> As Marco said, please just declare no_hash_pointers in this file as > well. Perhaps with a comment about not accessing it unless one has good > reason, but I suppose that's true in general for all kernel global > variables, so maybe not worth it for this one.
Sure, thank you for the review!
-- With Best Regards, Andy Shevchenko
| |