Messages in this thread | | | Date | Fri, 4 Aug 2023 10:27:07 -0700 | Subject | Re: [PATCH 2/4] KVM: selftests: Add helper macros for ioctl()s that return file descriptors | From | Sean Christopherson <> |
| |
On Fri, Aug 04, 2023, Oliver Upton wrote: > Hi Sean, > > On Thu, Aug 03, 2023 at 05:42:24PM -0700, Sean Christopherson wrote: > > Add KVM, VM, and vCPU scoped helpers for ioctl()s that return file > > descriptors, i.e. deduplicate code for asserting success on ioctls() for > > which a positive return value, not just zero, is considered success. > > > > Signed-off-by: Sean Christopherson <seanjc@google.com> > > I appreciate the desire to eliminate duplicate code, but I think the > naming just muddies the waters. TBH, when I first read the diff w/o the > changelog, I thought you were describing the input fd (i.e. 'kvm_fd', > 'vm_fd', 'vcpu_fd'). I don't think explicitly spelling out the condition > each time (i.e. ret >= 0) is all that difficult.
Yeah, but it's not just a desire to dedup code, I also am trying to funnel as many "ioctl() succeeded" asserts as possible into common code so that they naturally benefit from things like patch 4 (detecting dead/bugged VMs).
I agree the naming sucks.
| |