Messages in this thread | | | Date | Fri, 4 Aug 2023 12:02:03 +0800 | Subject | Re: [RFC PATCH net-next 2/6] net/smc: add vendor unique experimental options area in clc handshake | From | Guangguan Wang <> |
| |
I will fix it in the next version.
Thanks, Guangguan Wang
On 2023/8/4 01:45, Simon Horman wrote: > On Thu, Aug 03, 2023 at 09:24:18PM +0800, Guangguan Wang wrote: > > ... > > Hi Guangguan Wang, > >> @@ -987,12 +991,12 @@ static int smc_clc_send_confirm_accept(struct smc_sock *smc, >> { >> struct smc_connection *conn = &smc->conn; >> struct smc_clc_msg_accept_confirm *clc; >> - struct smc_clc_first_contact_ext fce; >> + struct smc_clc_first_contact_ext_v2x fce; >> struct smc_clc_fce_gid_ext gle; >> struct smc_clc_msg_trail trl; >> struct kvec vec[5]; >> struct msghdr msg; >> - int i, len; >> + int i, len, fce_len; > > Please preserve reverse xmas tree - longest line to shortest - > for local variable declarations: this is Networking code. > > https://github.com/ecree-solarflare/xmastree is your friend here. > > ...
| |