Messages in this thread | | | Date | Thu, 31 Aug 2023 14:25:47 -0700 | Subject | Re: [PATCH v4 6/8] selftests/resctrl: Make benchmark command const and build it with pointers | From | Reinette Chatre <> |
| |
Hi Ilpo,
On 8/31/2023 4:08 AM, Ilpo Järvinen wrote: > Benchmark command is used in multiple tests so it should not be > mutated by the tests but CMT test alters span argument. Due to the > order of tests (CMT test runs last), mutating the span argument in CMT > test does not trigger any real problems currently. > > Mark benchmark_cmd strings as const and setup the benchmark command > using pointers. Because the benchmark command becomes const, the input > arguments can be used directly. Besides being simpler, using the input > arguments directly also removes the internal size restriction. > > CMT test has to create a copy of the benchmark command before altering > the benchmark command. > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com> > Reviewed-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com> > ---
Thank you.
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
| |