Messages in this thread | | | From | Naresh Solanki <> | Date | Fri, 1 Sep 2023 00:11:49 +0530 | Subject | Re: [PATCH v4 1/3] dt-bindings: hwmon: Add Infineon TDA38640 |
| |
Hi
On Thu, 31 Aug 2023 at 21:24, Conor Dooley <conor@kernel.org> wrote: > > On Thu, Aug 31, 2023 at 12:49:32AM +0530, Naresh Solanki wrote: > > Hi > > > > On Wed, 30 Aug 2023 at 21:02, Conor Dooley <conor@kernel.org> wrote: > > > On Wed, Aug 30, 2023 at 12:36:16PM +0200, Naresh Solanki wrote: > > > > > + Indicates that the chip ENABLE pin is at fixed level or left > > > > + unconnected(has internal pull-down). > > > > > > Maybe you've already been over this, but if the pin is called "enable" > > > why not use the same wording in the property? > > EN & ENABLE is used interchangeably in the datasheet. > > Maybe we can go 1 for 2 in terms of consistency then, rather than 0 for > 2. Ack. Will go for EN as that's what is mentioned as pin name in datasheet. > > > Just to keep property name short I use EN. > > Consistency & readability trump brevity. Please pick one term, or point > out that this is called two things in the datasheet. Sure will pick one. i.e., EN. EN is pin name & description as mentioned in datasheet is 'Enable pin to turn on and off the IC'
Regards, Naresh
>
| |