Messages in this thread | | | From | "Luck, Tony" <> | Subject | RE: [PATCH v5 8/8] selftests/resctrl: Adjust effective L3 cache size when SNC enabled | Date | Thu, 31 Aug 2023 17:04:31 +0000 |
| |
> So it would look like this: > > while ((fscanf(fp, "%x", c)) != EOF ) { > if (c > 0xF) > continue; > count = __builtin_popcount(c); > } > > Are there some problems with an approach like that?
I think I'd prefer something that does more checking on the input (e.g. the hex numbers are separated by "," and terminated with a '\n').
If Shuah Khan doesn't like my original patch I can re-write to use fscanf() et. al.
-Tony
| |