lkml.org 
[lkml]   [2023]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers
On Thu, Aug 31, 2023 at 09:09:37AM +0100, Biju Das wrote:
> Having conditional around the of_node pointers turns out to make driver
> code use ugly #ifdef and #if blocks. So drop the conditionals.

...

> anx78xx->bridge.of_node = client->dev.of_node;

> panel_bridge->bridge.of_node = panel->dev->of_node;

> hdmi->bridge.of_node = pdev->dev.of_node;

> dsi->bridge.of_node = pdev->dev.of_node;

Yeah, I would really switch all of these to

bridge->fwnode = dev_fwnode(...);

But it's a suggestion for a separate change that I think can happen
sooner than later.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2023-08-31 18:18    [W:0.102 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site